Skip to content

Implement calendar layout#5451

Open
SShapovalov1 wants to merge 1 commit into
mate-academy:masterfrom
SShapovalov1:develop
Open

Implement calendar layout#5451
SShapovalov1 wants to merge 1 commit into
mate-academy:masterfrom
SShapovalov1:develop

Conversation

@SShapovalov1

Copy link
Copy Markdown
  • DEMO LINK

  • TEST REPORT LINK

  • Changing 'month-lengh' and 'start-day' modifier in the code element reflects in changing calendar layout

  • Each day has no modifiers, only class (eg. calendar__day)

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because it meets all the functional and checklist requirements for the calendar component. The calendar is correctly centered with flexbox, has exactly 31 .calendar__day elements without numbers in the HTML, and all day sizing, colors, hover effects (pointer, pink #FFBFCB, translate up 20px, 0.5s transition), and layout calculations via SCSS variables are implemented as required. The calendar--start-day-* and calendar--month-length-* modifiers are generated using SCSS loops and maps, correctly shifting the first day with margin-left and hiding extra days via nth-child, which aligns with the task’s expectations and [CHECKLIST ITEM #1]. You also respected BEM by keeping modifiers on the calendar block and using only .calendar__day for cells, satisfying [CHECKLIST ITEM #2].

The only notable mismatch with the typical spec is that your styles live in src/styles/index.scss instead of src/styles/main.scss, which could matter in a different setup, but it does not break the required functionality here. If your project setup expects main.scss, you can easily fix this by renaming the file and updating the <link> in index.html to point to the new name. Overall, this is a solid, clean implementation that uses SCSS features effectively—well done.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants